Not Remove Non-Closable Arc Popup When Close Button is Pressed

ui/arc/notification/arc_custom_notification_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ARC_NOTIFICATION_ARC_CUSTOM_NOTIFICATION_VIEW_H_
 #define UI_ARC_NOTIFICATION_ARC_CUSTOM_NOTIFICATION_VIEW_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 17 matching lines @@
 
 namespace arc {
 
 class ArcCustomNotificationView
     : public views::NativeViewHost,
       public views::ButtonListener,
       public aura::WindowObserver,
       public ArcCustomNotificationItem::Observer,
       public ArcNotificationSurfaceManager::Observer {
  public:
-  explicit ArcCustomNotificationView(ArcCustomNotificationItem* item);
+  ArcCustomNotificationView(ArcCustomNotificationItem* item);

[xiyuan, 2017/03/02 20:39:51]

"explicit" is required for single arg constructor per style guide.

https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

[yoshiki, 2017/03/03 01:22:04]

Done.

   ~ArcCustomNotificationView() override;
 
   std::unique_ptr<message_center::CustomNotificationContentViewDelegate>
   CreateContentViewDelegate();
 
  private:
   class ContentViewDelegate;
   class ControlButton;
   class EventForwarder;
   class SettingsButton;
@@ skipping 31 matching lines @@
   void OnWindowDestroying(aura::Window* window) override;
 
   // ArcCustomNotificationItem::Observer
   void OnItemDestroying() override;
   void OnItemUpdated() override;
 
   // ArcNotificationSurfaceManager::Observer:
   void OnNotificationSurfaceAdded(exo::NotificationSurface* surface) override;
   void OnNotificationSurfaceRemoved(exo::NotificationSurface* surface) override;
 
-  ArcCustomNotificationItem* item_ = nullptr;
+  ArcCustomNotificationItem* item_;

[xiyuan, 2017/03/02 20:39:51]

nit: Why do we need to change this? It would be useful if the constructor is
changed later and forget to initialize this.

[yoshiki, 2017/03/03 01:22:04]

Oops, you're right. Reverted.

   exo::NotificationSurface* surface_ = nullptr;
 
   const std::string notification_key_;
 
   // A pre-target event handler to forward events on the surface to this view.
   // Using a pre-target event handler instead of a target handler on the surface
   // window because it has descendant aura::Window and the events on them need
   // to be handled as well.
   // TODO(xiyuan): Revisit after exo::Surface no longer has an aura::Window.
   std::unique_ptr<EventForwarder> event_forwarder_;
@@ skipping 14 matching lines @@
 
   // Protects from call loops between Layout and OnWindowBoundsChanged.
   bool in_layout_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(ArcCustomNotificationView);
 };
 
 }  // namespace arc
 
 #endif  // UI_ARC_NOTIFICATION_ARC_CUSTOM_NOTIFICATION_VIEW_H_