Change MockHttpCache constructor to take boolean to set quic server info factory

Change MockHttpCache constructor to take boolean to set up quic server info factory. 

BUG=686632
Review-Url: https://codereview.chromium.org/2668563002
Cr-Commit-Position: refs/heads/master@{#447690}
Committed: https://chromium.googlesource.com/chromium/src/+/fcd1397490a75238764689ac720275a83721fa2d

[Zhongyi Shi, 2017-01-30 23:36:44]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 23:37:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:20:07]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2017-01-31 01:14:30]

Description was changed from

==========
Change MockHttpCache constructor to take boolean to set whether quic server info
should be set

BUG=686632
==========

to

==========
Change MockHttpCache constructor to take boolean to set quic server info
factory. 

BUG=686632
==========

[Zhongyi Shi, 2017-01-31 01:14:31]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2017-01-31 01:14:51]

Patchset #1 (id:1) has been deleted

[Ryan Hamilton, 2017-01-31 01:32:26]

https://codereview.chromium.org/2668563002/diff/20001/net/http/http_cache_loo...
File net/http/http_cache_lookup_manager_unittest.cc (right):

https://codereview.chromium.org/2668563002/diff/20001/net/http/http_cache_loo...
net/http/http_cache_lookup_manager_unittest.cc:86: MockHttpCache
mock_cache(false);
You might also consider keeping the old no-arg constructor to make this CL
smaller. But totally up to you.

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cache.h
File net/http/mock_http_cache.h (right):

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cach...
net/http/mock_http_cache.h:182: MockHttpCache(bool set_up_quic_server_info);
nit: can you comment what this param means? Also, please add explicit.

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cach...
net/http/mock_http_cache.h:183: explicit MockHttpCache(
explicit is no longer needed.

[Zhongyi Shi, 2017-02-02 01:05:13]

Ryan, PTAL!

https://codereview.chromium.org/2668563002/diff/20001/net/http/http_cache_loo...
File net/http/http_cache_lookup_manager_unittest.cc (right):

https://codereview.chromium.org/2668563002/diff/20001/net/http/http_cache_loo...
net/http/http_cache_lookup_manager_unittest.cc:86: MockHttpCache
mock_cache(false);
On 2017/01/31 01:32:26, Ryan Hamilton wrote:
> You might also consider keeping the old no-arg constructor to make this CL
> smaller. But totally up to you.

Done.

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cache.h
File net/http/mock_http_cache.h (right):

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cach...
net/http/mock_http_cache.h:182: MockHttpCache(bool set_up_quic_server_info);
On 2017/01/31 01:32:26, Ryan Hamilton wrote:
> nit: can you comment what this param means? Also, please add explicit.

Done.

https://codereview.chromium.org/2668563002/diff/20001/net/http/mock_http_cach...
net/http/mock_http_cache.h:183: explicit MockHttpCache(
On 2017/01/31 01:32:26, Ryan Hamilton wrote:
> explicit is no longer needed.

Done.

[Ryan Hamilton, 2017-02-02 01:07:10]

https://codereview.chromium.org/2668563002/diff/60001/net/http/http_cache_uni...
File net/http/http_cache_unittest.cc (right):

https://codereview.chromium.org/2668563002/diff/60001/net/http/http_cache_uni...
net/http/http_cache_unittest.cc:650: MockHttpCache
cache(HttpCache::DefaultBackend::InMemory(0), false);
I think you can revert these changes now, right?

[Zhongyi Shi, 2017-02-02 01:31:22]

Description was changed from

==========
Change MockHttpCache constructor to take boolean to set quic server info
factory. 

BUG=686632
==========

to

==========
Change MockHttpCache constructor to take boolean to set up quic server info
factory. 

BUG=686632
==========

[Zhongyi Shi, 2017-02-02 01:32:14]

https://codereview.chromium.org/2668563002/diff/60001/net/http/http_cache_uni...
File net/http/http_cache_unittest.cc (right):

https://codereview.chromium.org/2668563002/diff/60001/net/http/http_cache_uni...
net/http/http_cache_unittest.cc:650: MockHttpCache
cache(HttpCache::DefaultBackend::InMemory(0), false);
On 2017/02/02 01:07:09, Ryan Hamilton wrote:
> I think you can revert these changes now, right?

Added one more constructor in the MockHttpCache so that we could get rid of this
change.

[Ryan Hamilton, 2017-02-02 01:45:00]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-02-02 01:45:00]

lgtm

[commit-bot: I haz the power, 2017-02-02 01:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 02:26:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485999900214080,
"parent_rev": "f2fb300bb003df54f9e6b8699fbb2d02077bc60c", "commit_rev":
"fcd1397490a75238764689ac720275a83721fa2d"}

[commit-bot: I haz the power, 2017-02-02 02:27:44]

Description was changed from

==========
Change MockHttpCache constructor to take boolean to set up quic server info
factory. 

BUG=686632
==========

to

==========
Change MockHttpCache constructor to take boolean to set up quic server info
factory. 

BUG=686632

Review-Url: https://codereview.chromium.org/2668563002
Cr-Commit-Position: refs/heads/master@{#447690}
Committed:
https://chromium.googlesource.com/chromium/src/+/fcd1397490a75238764689ac7202...
==========

[commit-bot: I haz the power, 2017-02-02 02:27:45]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fcd1397490a75238764689ac7202...