Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2668553003: Instant Apps: Remove experiment. (Closed)

Created:
3 years, 10 months ago by Maria
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Remove experiment. Since we are launching to 100%, remove the experiment and all the flags associated with it. BUG=687234 Review-Url: https://codereview.chromium.org/2668553003 Cr-Commit-Position: refs/heads/master@{#448054} Committed: https://chromium.googlesource.com/chromium/src/+/d6c9a754a1e61690287f87051318c1ccac8d063c

Patch Set 1 #

Patch Set 2 : Remove tests for experiment enabled. #

Patch Set 3 : Rebase #

Messages

Total messages: 19 (10 generated)
Maria
3 years, 10 months ago (2017-01-31 17:51:49 UTC) #2
Ted C
lgtm...do they have the ability to disable their stuff server side if we start seeing ...
3 years, 10 months ago (2017-01-31 19:02:17 UTC) #3
Maria
On 2017/01/31 19:02:17, Ted C wrote: > lgtm...do they have the ability to disable their ...
3 years, 10 months ago (2017-01-31 19:59:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668553003/1
3 years, 10 months ago (2017-02-01 19:38:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/224352)
3 years, 10 months ago (2017-02-01 21:12:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668553003/20001
3 years, 10 months ago (2017-02-01 21:29:38 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-01 22:49:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668553003/40001
3 years, 10 months ago (2017-02-03 18:44:44 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:43:53 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d6c9a754a1e61690287f87051318...

Powered by Google App Engine
This is Rietveld 408576698