Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2668503008:
implement unlink on Windows (Closed)
Descriptionimplement unlink on Windows
unlink on Windows uses DeleteFileW and RemoveDirectoryW to delete
the symlink and not the link source.
Relevant MSDN articles:
CreateSymbolicLink: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=vs.85).aspx
DeleteFile: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363915(v=vs.85).aspx
RemoveDirectory: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx
R=maruel@chromium.org, vadimsh@chromium.org
BUG=661390
Review-Url: https://codereview.chromium.org/2668503008
Committed: https://github.com/luci/luci-py/commit/fb391a2976db77b810e1178c0aaed972d6eaf4f4
Patch Set 1 #Patch Set 2 : docs #Patch Set 3 : pylint #Patch Set 4 : implement unlink on Windows #Patch Set 5 : pylint... #Messages
Total messages: 29 (17 generated)
Description was changed from ========== implement unlink on Windows unlink uses DeleteFileW and RemoveDirectoryW to delete the symlink and not the link source. Relevant MSDN articles: CreateSymbolicLink: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=vs.85).aspx DeleteFile: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363915(v=vs.85).aspx RemoveDirectory: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx R=maruel@chromium.org, vadimsh@chromium.org BUG=661390 ========== to ========== implement unlink on Windows unlink on Windows uses DeleteFileW and RemoveDirectoryW to delete the symlink and not the link source. Relevant MSDN articles: CreateSymbolicLink: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=vs.85).aspx DeleteFile: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363915(v=vs.85).aspx RemoveDirectory: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx R=maruel@chromium.org, vadimsh@chromium.org BUG=661390 ==========
PTAL Verified DeleteFile and RemoveDirectory on a symlink on vm304-m4 (Windows 7)
(writing tests)
hm, we don't run swarming tests on windows
The CQ bit was checked by maruel@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/341449722078ee10)
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/2668503008/#ps40001 (title: "pylint")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3414c72de1396710)
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/2668503008/#ps60001 (title: "implement unlink on Windows")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3414ec56cade4a10)
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/2668503008/#ps80001 (title: "pylint...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486005617673820,
"parent_rev": "a93ce5abfcc7054c20de9cbaf296e1176bd0155e", "commit_rev":
"fb391a2976db77b810e1178c0aaed972d6eaf4f4"}
Message was sent while issue was closed.
Description was changed from ========== implement unlink on Windows unlink on Windows uses DeleteFileW and RemoveDirectoryW to delete the symlink and not the link source. Relevant MSDN articles: CreateSymbolicLink: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=vs.85).aspx DeleteFile: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363915(v=vs.85).aspx RemoveDirectory: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx R=maruel@chromium.org, vadimsh@chromium.org BUG=661390 ========== to ========== implement unlink on Windows unlink on Windows uses DeleteFileW and RemoveDirectoryW to delete the symlink and not the link source. Relevant MSDN articles: CreateSymbolicLink: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=vs.85).aspx DeleteFile: https://msdn.microsoft.com/en-us/library/windows/desktop/aa363915(v=vs.85).aspx RemoveDirectory: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx R=maruel@chromium.org, vadimsh@chromium.org BUG=661390 Review-Url: https://codereview.chromium.org/2668503008 Committed: https://github.com/luci/luci-py/commit/fb391a2976db77b810e1178c0aaed972d6eaf4f4 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://github.com/luci/luci-py/commit/fb391a2976db77b810e1178c0aaed972d6eaf4f4 |
