Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2668443002: Fix sensors layout tests flakiness (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, Reilly Grant (use Gerrit), timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sensors layout tests flakiness Before the change frequency hint tests were flaky with the following error message: FAIL Test that frequency hint works (onchange reporting). assert_equals: expected 3 but got 2. The reason apparently was that notification on Blink side sometimes gets slightly delayed (which is possible behavior since it is bound to AF) BUG=680043 Review-Url: https://codereview.chromium.org/2668443002 Cr-Commit-Position: refs/heads/master@{#447218} Committed: https://chromium.googlesource.com/chromium/src/+/bf0871ef36416a7ac4bafba5bea3bdd8ad733f0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-01-30 17:12:22 UTC) #5
haraken
LGTM
3 years, 10 months ago (2017-01-30 17:13:27 UTC) #6
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-01-30 18:02:22 UTC) #8
shalamov
lgtm
3 years, 10 months ago (2017-01-31 07:52:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668443002/1
3 years, 10 months ago (2017-01-31 11:53:59 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 11:58:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf0871ef36416a7ac4bafba5bea3...

Powered by Google App Engine
This is Rietveld 408576698