Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2668423007: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, shalamov, mlamouri+watch-blink_chromium.org, riju_, jam, abarth-chromium, haraken, dglazkov+blink, darin-cc_chromium.org, wanming.lin, mlamouri+watch-sensors_chromium.org, blink-reviews, blink-reviews-api_chromium.org, android-webview-reviews_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2668423007 Cr-Commit-Position: refs/heads/master@{#451387} Committed: https://chromium.googlesource.com/chromium/src/+/d15ea4791d38c7fa37969739862fd16adcdc341c

Patch Set 1 #

Total comments: 20

Patch Set 2 : remove improper component #

Total comments: 4

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M android_webview/tools/system_webview_shell/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/tools/system_webview_shell/apk/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M android_webview/tools/system_webview_shell/layout_tests/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M components/safe_browsing/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/device_sensors/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/device_sensors/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M device/sensors/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M device/vibration/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/device_orientation/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-03 00:10:25 UTC) #1
timvolodine
Hi, a number of components seem to be off, I have provided some comments, but ...
3 years, 10 months ago (2017-02-08 16:44:48 UTC) #2
ymzhang1
Thanks for the comments! I used a prediction model to get component candidate for OWNERS ...
3 years, 10 months ago (2017-02-10 18:58:53 UTC) #3
timvolodine
https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS File content/browser/battery_status/OWNERS (right): https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS#newcode4 content/browser/battery_status/OWNERS:4: # COMPONENT: UI>Browser On 2017/02/10 18:58:53, ymzhang1 wrote: > ...
3 years, 10 months ago (2017-02-16 17:14:57 UTC) #6
ymzhang1
On 2017/02/16 17:14:57, timvolodine wrote: > https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS > File content/browser/battery_status/OWNERS (right): > > https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS#newcode4 > ...
3 years, 10 months ago (2017-02-16 22:21:13 UTC) #7
ymzhang1
https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS File content/browser/battery_status/OWNERS (right): https://codereview.chromium.org/2668423007/diff/1/content/browser/battery_status/OWNERS#newcode4 content/browser/battery_status/OWNERS:4: # COMPONENT: UI>Browser On 2017/02/16 17:14:57, timvolodine wrote: > ...
3 years, 10 months ago (2017-02-16 23:17:52 UTC) #9
timvolodine
few more fixes, otherwise looks fine https://codereview.chromium.org/2668423007/diff/40001/android_webview/tools/system_webview_shell/apk/OWNERS File android_webview/tools/system_webview_shell/apk/OWNERS (right): https://codereview.chromium.org/2668423007/diff/40001/android_webview/tools/system_webview_shell/apk/OWNERS#newcode3 android_webview/tools/system_webview_shell/apk/OWNERS:3: # COMPONENT: Infra>Client>Android ...
3 years, 10 months ago (2017-02-17 14:13:20 UTC) #10
ymzhang1
Updated. Thanks! https://codereview.chromium.org/2668423007/diff/40001/android_webview/tools/system_webview_shell/apk/OWNERS File android_webview/tools/system_webview_shell/apk/OWNERS (right): https://codereview.chromium.org/2668423007/diff/40001/android_webview/tools/system_webview_shell/apk/OWNERS#newcode3 android_webview/tools/system_webview_shell/apk/OWNERS:3: # COMPONENT: Infra>Client>Android On 2017/02/17 14:13:20, timvolodine ...
3 years, 10 months ago (2017-02-17 17:53:53 UTC) #11
timvolodine
On 2017/02/17 17:53:53, ymzhang1 wrote: > Updated. Thanks! > > https://codereview.chromium.org/2668423007/diff/40001/android_webview/tools/system_webview_shell/apk/OWNERS > File android_webview/tools/system_webview_shell/apk/OWNERS (right): ...
3 years, 10 months ago (2017-02-17 19:51:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668423007/60001
3 years, 10 months ago (2017-02-17 20:32:47 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 22:28:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d15ea4791d38c7fa37969739862f...

Powered by Google App Engine
This is Rietveld 408576698