Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2668423002: Chrome should send cookieless request to WebAPK server. (Closed)

Created:
3 years, 10 months ago by Xi Han
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Chrome should send cookieless request to WebAPK server. WebAPK server only takes the user agent from the request sent from Chrome, and ignores cookies. From security perspective, it is safer to send request without any cookie. Therefore, we add flag to exlude cookies from the request to the WebAPK server. BUG=687191 Review-Url: https://codereview.chromium.org/2669463004 Cr-Commit-Position: refs/heads/master@{#447282} (cherry picked from commit 3faa6994cce92431aa1ba5179aa92e3a45a7bb91) Review-Url: https://codereview.chromium.org/2668423002 . Cr-Commit-Position: refs/branch-heads/2987@{#256} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/aa76e887d1add5c2ad4172a47b324849f83b5dbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/android/webapk/webapk_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Xi Han
3 years, 10 months ago (2017-02-01 23:27:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa76e887d1add5c2ad4172a47b324849f83b5dbd.

Powered by Google App Engine
This is Rietveld 408576698