DevTools: rebaseline DOM / CSS / Elements tests

DevTools: rebaseline DOM / CSS / Elements tests

BUG=682078
Review-Url: https://codereview.chromium.org/2668403004
Cr-Commit-Position: refs/heads/master@{#448382}
Committed: https://chromium.googlesource.com/chromium/src/+/4660c749a14cf8d15440dc99595e226b8d1a2dd6

[chenwilliam, 2017-02-02 23:32:54]

Description was changed from

==========
DevTools: rebaseline DOM / elements / acccessibility tests

BUG=682078
==========

to

==========
DevTools: rebaseline DOM & CSS tests

BUG=682078
==========

[chenwilliam, 2017-02-02 23:32:54]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-02-02 23:37:03]

Description was changed from

==========
DevTools: rebaseline DOM & CSS tests

BUG=682078
==========

to

==========
DevTools: rebaseline DOM / CSS / Elements tests

BUG=682078
==========

[chenwilliam, 2017-02-02 23:37:17]

ptal

[aboxhall, 2017-02-03 01:40:58]

aboxhall@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2017-02-03 01:40:58]

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt:3:
error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
wasn't found
This now has an error...

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt:4:
error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
wasn't found
As does this.

[chenwilliam, 2017-02-03 02:14:12]

On 2017/02/03 01:40:58, aboxhall wrote:
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt:3:
> error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
> wasn't found
> This now has an error...
> 
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt:4:
> error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
> wasn't found
> As does this.


@aboxhall - these errors are happening because this is testing against a
historic content shell (when protocol 1.2 was branched). Because the protocol
method Accessibility.getPartialAXTree didn't exist yet, these baselines for
protocol-1.2 are showing errors. It's not super meaningful, but these test at
least show nothing is crashing devtools / throwing an error. These aren't
changing the actual baselines (tip-of-tree) which are run on the main chromium
waterfall and the plan is to run these in addition on an optional trybot to
manage backwards compatibility. Please take a look at the crbug linked for more
context.

[aboxhall, 2017-02-03 02:21:15]

On 2017/02/03 02:14:12, chenwilliam wrote:
> On 2017/02/03 01:40:58, aboxhall wrote:
> >
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> > File
> >
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt
> > (right):
> > 
> >
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> >
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt:3:
> > error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
> > wasn't found
> > This now has an error...
> > 
> >
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> > File
> >
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt
> > (right):
> > 
> >
>
https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
> >
>
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt:4:
> > error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
> > wasn't found
> > As does this.
> 
> 
> @aboxhall - these errors are happening because this is testing against a
> historic content shell (when protocol 1.2 was branched). Because the protocol
> method Accessibility.getPartialAXTree didn't exist yet, these baselines for
> protocol-1.2 are showing errors. It's not super meaningful, but these test at
> least show nothing is crashing devtools / throwing an error. These aren't
> changing the actual baselines (tip-of-tree) which are run on the main chromium
> waterfall and the plan is to run these in addition on an optional trybot to
> manage backwards compatibility. Please take a look at the crbug linked for
more
> context.

Got it, thanks for the explanation!

[chenwilliam, 2017-02-06 18:58:18]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-02-06 18:58:18]

pfeldman@, ptal.

[pfeldman, 2017-02-06 19:02:49]

I would skip a11y tests for clarity. Otherwise lgtm.

[chenwilliam, 2017-02-06 19:20:41]

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/autocomplete-attribute-expected.txt:3:
error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
wasn't found
On 2017/02/03 01:40:58, aboxhall wrote:
> This now has an error...

Removed baseline & skipping test for clarity.

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/elements/accessibility/edit-aria-attributes-expected.txt:4:
error: AccessibilityAgent.getAXNodeChain(): 'Accessibility.getPartialAXTree'
wasn't found
On 2017/02/03 01:40:58, aboxhall wrote:
> As does this.

Removed baseline & skipping test for clarity.

[chenwilliam, 2017-02-06 19:20:44]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-02-06 19:20:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2668403004/#ps40001
(title: "remove ax baselines")

[commit-bot: I haz the power, 2017-02-06 19:21:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-06 19:39:03]

btw,

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/css/css-get-background-colors-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/css/css-get-background-colors-expected.txt:45:
{"backgroundColors":["rgb(255, 128, 128)"]}
do we know why?

[chenwilliam, 2017-02-06 19:45:52]

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/css/css-get-background-colors-expected.txt
(right):

https://codereview.chromium.org/2668403004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/css/css-get-background-colors-expected.txt:45:
{"backgroundColors":["rgb(255, 128, 128)"]}
On 2017/02/06 19:39:03, pfeldman wrote:
> do we know why?

https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a...

[pfeldman, 2017-02-06 19:46:54]

>
https://chromium.googlesource.com/chromium/src/+/fdab33b3484cd6e1259015d0387a...

got it, thanks!

[commit-bot: I haz the power, 2017-02-06 20:43:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486408844961970,
"parent_rev": "a50ba2443866205ce731d093b348dab2a21c9184", "commit_rev":
"4660c749a14cf8d15440dc99595e226b8d1a2dd6"}

[commit-bot: I haz the power, 2017-02-06 20:44:25]

Description was changed from

==========
DevTools: rebaseline DOM / CSS / Elements tests

BUG=682078
==========

to

==========
DevTools: rebaseline DOM / CSS / Elements tests

BUG=682078

Review-Url: https://codereview.chromium.org/2668403004
Cr-Commit-Position: refs/heads/master@{#448382}
Committed:
https://chromium.googlesource.com/chromium/src/+/4660c749a14cf8d15440dc99595e...
==========

[commit-bot: I haz the power, 2017-02-06 20:44:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4660c749a14cf8d15440dc99595e...