Issue 2668383005: Report reasons for a negative histogram sample count.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2668383005: Report reasons for a negative histogram sample count. (Closed)

Created:
3 years, 10 months ago by bcwhite

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Report reasons for a negative histogram sample count. Samples reported this way will also be prevented from going negative during the upload. BUG=682680 Review-Url: https://codereview.chromium.org/2644143006 Cr-Commit-Position: refs/heads/master@{#445177} (cherry picked from commit 48897934e17d9043535dd1213738cb5fce8bda89) Review-Url: https://codereview.chromium.org/2668383005 . Cr-Commit-Position: refs/branch-heads/2987@{#279} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a4b4ad0aea38aa1440b90908d436131dbdf3b395

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
	M	base/metrics/persistent_sample_map.cc	View		3 chunks	+35 lines, -0 lines	0 comments	Download
	M	tools/metrics/histograms/histograms.xml	View		2 chunks	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

bcwhite

3 years, 10 months ago (2017-02-02 20:16:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4b4ad0aea38aa1440b90908d436131dbdf3b395.