[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use NS_ENUM macro.

BUG=680731
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668353003
Cr-Commit-Position: refs/heads/master@{#447813}
Committed: https://chromium.googlesource.com/chromium/src/+/289293b5aeb0d4eed997ec0fb2f5088b0db66d92

[lilyhoughton1, 2017-02-01 19:37:11]

Description was changed from

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=
==========

to

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[lilyhoughton, 2017-02-01 19:39:30]

Description was changed from

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[lilyhoughton, 2017-02-01 19:39:30]

lilyhoughton@chromium.org changed reviewers:
+ mef@google.com

[lilyhoughton, 2017-02-01 19:39:47]

PTAL

[mef, 2017-02-01 19:43:31]

mef@chromium.org changed reviewers:
+ mef@chromium.org, robgaunt@google.com
- mef@google.com

[mef, 2017-02-01 19:43:31]

Thanks Lily, this looks good to me, could you add bug number?

Rob, could you confirm whether this is all that's needed for cache type?

[robgaunt, 2017-02-01 19:46:44]

https://codereview.chromium.org/2668353003/diff/1/components/cronet/ios/Cronet.h
File components/cronet/ios/Cronet.h (right):

https://codereview.chromium.org/2668353003/diff/1/components/cronet/ios/Crone...
components/cronet/ios/Cronet.h:15: typedef NS_ENUM(NSInteger, CRNHttpCacheType)
{
In objective-C, acronyms and initialisms are conventionally left upper-case. So:
CRNHTTPCacheType

(For example, in iOS system frameworks we have NSURL, NSHTTPURLResponse, etc.)

However, it's OK with me if you want to keep "Http" for consistency with
existing usage in this file.

[lilyhoughton, 2017-02-01 20:06:52]

Description was changed from

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=680731
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-02-02 18:23:18]

On 2017/02/01 19:46:44, robgaunt wrote:
>
https://codereview.chromium.org/2668353003/diff/1/components/cronet/ios/Cronet.h
> File components/cronet/ios/Cronet.h (right):
> 
>
https://codereview.chromium.org/2668353003/diff/1/components/cronet/ios/Crone...
> components/cronet/ios/Cronet.h:15: typedef NS_ENUM(NSInteger,
CRNHttpCacheType)
> {
> In objective-C, acronyms and initialisms are conventionally left upper-case.
So:
> CRNHTTPCacheType
> 
> (For example, in iOS system frameworks we have NSURL, NSHTTPURLResponse, etc.)
> 
> However, it's OK with me if you want to keep "Http" for consistency with
> existing usage in this file.

Rob, thanks! We've looked at this file and there is a lot of Http, so we'll keep
it for now and revisit with API refactor.
lgtm.

[robgaunt, 2017-02-02 18:26:01]

lgtm

[lilyhoughton, 2017-02-02 18:29:14]

The CQ bit was checked by lilyhoughton@chromium.org

[commit-bot: I haz the power, 2017-02-02 18:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 19:15:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486060154455620, "parent_rev":
"bd39ee6aee08c93647e9174347d7926e58b11012", "commit_rev":
"289293b5aeb0d4eed997ec0fb2f5088b0db66d92"}

[commit-bot: I haz the power, 2017-02-02 19:16:40]

Description was changed from

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=680731
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] make HttpCacheType enum more comfortative to Obj-C style.

Add 3-letter class prefix (CRN), prefix enum values with enum name, and use
NS_ENUM macro.

BUG=680731
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2668353003
Cr-Commit-Position: refs/heads/master@{#447813}
Committed:
https://chromium.googlesource.com/chromium/src/+/289293b5aeb0d4eed997ec0fb2f5...
==========

[commit-bot: I haz the power, 2017-02-02 19:16:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/289293b5aeb0d4eed997ec0fb2f5...