[ES6 modules] Introduce ModuleScriptLoaderClient

[ES6 modules] Introduce ModuleScriptLoaderClient

This CL introduces ModuleScriptLoaderClient interface,
which will be used to notify a single module script load completion.

BUG=594639
Review-Url: https://codereview.chromium.org/2668283003
Cr-Commit-Position: refs/heads/master@{#453135}
Committed: https://chromium.googlesource.com/chromium/src/+/4894c4d4256b453b617346f29cfd81487dbffa56

[kouhei (in TOK), 2017-02-01 22:12:56]

kouhei@chromium.org changed reviewers:
+ haraken@chromium.org, hiroshige@chromium.org, yhirano@chromium.org

[kouhei (in TOK), 2017-02-01 22:12:57]

PTAL

I'd like to land this interface, so that I can have ModuleMap and
ModuleScriptLoader CLs reviewed concurrently which both depend on this
interface.

[kouhei (in TOK), 2017-02-01 22:13:06]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 22:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-01 22:16:01]

On 2017/02/01 22:12:57, kouhei_at_blinkon wrote:
> PTAL
> 
> I'd like to land this interface, so that I can have ModuleMap and
> ModuleScriptLoader CLs reviewed concurrently which both depend on this
> interface.

LGTM (though I'm not really happy about adding unused things to the trunk).

[kouhei (in TOK), 2017-02-01 22:18:57]

On 2017/02/01 22:16:01, haraken wrote:
> On 2017/02/01 22:12:57, kouhei_at_blinkon wrote:
> > PTAL
> > 
> > I'd like to land this interface, so that I can have ModuleMap and
> > ModuleScriptLoader CLs reviewed concurrently which both depend on this
> > interface.
> 
> LGTM (though I'm not really happy about adding unused things to the trunk).

Thanks. I'll make the CLs depend on this one, so I can check the CQ once either
of the CLs got lgtmed.

[yhirano, 2017-02-01 23:53:14]

Out of curiosity, is this private pure virtual + friend class more preferable
than public pure virtual in general?

[kouhei (in TOK), 2017-02-01 23:58:29]

On 2017/02/01 23:53:14, yhirano (slow) wrote:
> Out of curiosity, is this private pure virtual + friend class more preferable
> than public pure virtual in general?
I want to make sure that ModuleScriptLoaderClient is not abused by other class.
ModuleScriptLoader (and the test mocks) should be the only class which
notifyNewSingleModuleFinished.

[commit-bot: I haz the power, 2017-02-02 00:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:08:14]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-02-02 00:16:28]

lgtm.

> I want to make sure that ModuleScriptLoaderClient is not abused by other
class.
> ModuleScriptLoader (and the test mocks) should be the only class which
> notifyNewSingleModuleFinished.
Adding a comment that states this intention might be helpful.

https://codereview.chromium.org/2668283003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderClient.h
(right):

https://codereview.chromium.org/2668283003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderClient.h:20:
virtual ~ModuleScriptLoaderClient(){};
nit: extra semicolon at the end of line.

[yhirano, 2017-02-02 16:36:09]

lgtm

[kouhei (in TOK), 2017-02-27 00:12:24]

I'll commit this CL now that ModuleMap cl is lgtmed.

[kouhei (in TOK), 2017-02-27 00:12:54]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-27 00:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, haraken@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2668283003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-27 00:13:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 01:47:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488154374877840,
"parent_rev": "636f441be350ec76e73b4e4f407bf8a7e86984fd", "commit_rev":
"4894c4d4256b453b617346f29cfd81487dbffa56"}

[commit-bot: I haz the power, 2017-02-27 01:49:19]

Description was changed from

==========
[ES6 modules] Introduce ModuleScriptLoaderClient

This CL introduces ModuleScriptLoaderClient interface,
which will be used to notify a single module script load completion.

BUG=594639
==========

to

==========
[ES6 modules] Introduce ModuleScriptLoaderClient

This CL introduces ModuleScriptLoaderClient interface,
which will be used to notify a single module script load completion.

BUG=594639

Review-Url: https://codereview.chromium.org/2668283003
Cr-Commit-Position: refs/heads/master@{#453135}
Committed:
https://chromium.googlesource.com/chromium/src/+/4894c4d4256b453b617346f29cfd...
==========

[commit-bot: I haz the power, 2017-02-27 01:49:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4894c4d4256b453b617346f29cfd...