Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2668263002: [NTP::Cleanup] Add brackets in snippets_internals_message_handler.cc. (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::Cleanup] Add brackets in snippets_internals_message_handler.cc. This CL adds curly brackets to |if|, |for| and |while| in snippets_internals_message_handler.cc. BUG=673667 Review-Url: https://codereview.chromium.org/2668263002 Cr-Commit-Position: refs/heads/master@{#447730} Committed: https://chromium.googlesource.com/chromium/src/+/e58c4d554ba4dd2c791da9fc132cfaf2e5a47c70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 7 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vitaliii
Hi jkrcal@, could you have a look?
3 years, 10 months ago (2017-02-02 08:57:17 UTC) #6
jkrcal
lgtm Generally speaking, I do not think it makes sense to go through our code ...
3 years, 10 months ago (2017-02-02 09:06:09 UTC) #7
vitaliii
On 2017/02/02 09:06:09, jkrcal wrote: > lgtm > > Generally speaking, I do not think ...
3 years, 10 months ago (2017-02-02 09:14:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668263002/1
3 years, 10 months ago (2017-02-02 09:15:57 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 09:19:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e58c4d554ba4dd2c791da9fc132c...

Powered by Google App Engine
This is Rietveld 408576698