Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2668203005: Reland allow JUnit3/4 tests within the same apk to be run by test_runner (Closed)

Created:
3 years, 10 months ago by the real yoland
Modified:
3 years, 10 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland allow JUnit3/4 tests within the same apk to be run by test_runner This CL change instrumentation_test_instance and other part of the test_runner script to embed the information whether a test class is junit3 or junit4. The confirmation mechanism is to check whether the class's direct parent is java.lang.Object. In junit3, all tests are decesdends from TestCase, while in junit4, all tests are suppose to be atomic (extends from Object) BUG=640116 Review-Url: https://codereview.chromium.org/2668203005 Cr-Commit-Position: refs/heads/master@{#447634} Committed: https://chromium.googlesource.com/chromium/src/+/dbe6848664fd910b6d924f2a0f59ea5fd311653d

Patch Set 1 #

Patch Set 2 : Change pickle version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -28 lines) Patch
M build/android/gyp/write_build_config.py View 3 chunks +15 lines, -17 lines 0 comments Download
M build/android/lint/suppressions.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 10 chunks +40 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance_test.py View 31 chunks +40 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 2 chunks +9 lines, -2 lines 0 comments Download
M build/android/pylib/utils/dexdump.py View 2 chunks +7 lines, -2 lines 0 comments Download
M build/android/pylib/utils/dexdump_test.py View 5 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
the real yoland
https://codereview.chromium.org/2668203005/diff2/1:20001/build/android/pylib/instrumentation/instrumentation_test_instance.py
3 years, 10 months ago (2017-02-01 21:48:47 UTC) #2
jbudorick
lgtm
3 years, 10 months ago (2017-02-01 21:51:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668203005/20001
3 years, 10 months ago (2017-02-01 21:53:56 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 23:06:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dbe6848664fd910b6d924f2a0f59...

Powered by Google App Engine
This is Rietveld 408576698