Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2668173003: [Sensors] Remove SensorReading interfaces (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, shalamov, jam, darin-cc_chromium.org, wanming.lin, blink-reviews, Mikhail, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Remove SensorReading interfaces The SensorReading interface has been recently excluded from W3C Generic Sensor specification [1]. Now concrete sensor interfaces should themselves contain reading attributes. Sensor layout and browser tests are updated accordingly. BUG=606766 [1] https://w3c.github.io/sensors/ Review-Url: https://codereview.chromium.org/2668173003 Cr-Commit-Position: refs/heads/master@{#447749} Committed: https://chromium.googlesource.com/chromium/src/+/38085832fa9b018027dd0aa2068afef12e37777b

Patch Set 1 #

Patch Set 2 : updated global-interface-listing.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -787 lines) Patch
M content/test/data/generic_sensor/ambient_light_sensor_test.html View 1 chunk +3 lines, -3 lines 0 comments Download
M device/generic_sensor/public/cpp/sensor_reading.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/accelerometer.html View 1 chunk +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/gyroscope.html View 1 chunk +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/idl-Accelerometer.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/idl-Gyroscope.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/idl-Magnetometer.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/magnetometer.html View 1 chunk +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 3 chunks +11 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 5 chunks +1 line, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 3 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.idl View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/sensor/AccelerometerReading.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AccelerometerReading.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AccelerometerReading.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AccelerometerReadingInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.idl View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReadingInit.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.cpp View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.idl View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/sensor/GyroscopeReading.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/GyroscopeReading.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/GyroscopeReadingInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.idl View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/sensor/MagnetometerReading.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/MagnetometerReading.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/MagnetometerReading.idl View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/MagnetometerReadingInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 5 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 6 chunks +42 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 4 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 8 chunks +3 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReading.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReading.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReading.idl View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-01 13:37:39 UTC) #3
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-01 22:19:12 UTC) #13
haraken
LGTM
3 years, 10 months ago (2017-02-01 22:19:31 UTC) #14
shalamov
lgtm I think you forgot to update global-interface-listing expectations.
3 years, 10 months ago (2017-02-02 07:13:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668173003/40001
3 years, 10 months ago (2017-02-02 12:29:38 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 12:54:24 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/38085832fa9b018027dd0aa2068a...

Powered by Google App Engine
This is Rietveld 408576698