Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2668163002: MD Settings: Fix styles in several places. (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
dschuyler, tommycli
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix styles in several places. - Some buttons were missing the "secondary-button"/"cancel-button" class. - removing rule-lines - remove unnecessary controls BUG=684152 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2668163002 Cr-Commit-Position: refs/heads/master@{#447923} Committed: https://chromium.googlesource.com/chromium/src/+/d8126246d566c209b04c3beb9a88b9258d37461c

Patch Set 1 #

Patch Set 2 : hide rule-line for media-picker, used in content settings > camera/mic #

Patch Set 3 : remove ok-google learn-more link #

Patch Set 4 : add capabilities for controlled-button to be an icon-button #

Patch Set 5 : remove rule-line on spell check page #

Total comments: 14

Patch Set 6 : touch ups on styles #

Patch Set 7 : remove unused content block from settings-toggle-button #

Patch Set 8 : accidentally removed a css block #

Patch Set 9 : revert changes to controlled_button (moving to another CL) #

Total comments: 2

Patch Set 10 : make password exception list less nested and tested more precisely #

Total comments: 1

Patch Set 11 : remove ugly for-unit-test-only class #

Messages

Total messages: 32 (19 generated)
scottchen
There's several misc. visual fixes in here, most of which are just adding class or ...
3 years, 10 months ago (2017-02-01 22:37:09 UTC) #9
tommycli
https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/controls/controlled_button.html File chrome/browser/resources/settings/controls/controlled_button.html (right): https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/controls/controlled_button.html#newcode42 chrome/browser/resources/settings/controls/controlled_button.html:42: <template is="dom-if" if="[[iconClass]]"> The controlled-button changes seem odd. I ...
3 years, 10 months ago (2017-02-01 22:54:49 UTC) #10
dschuyler
Nice, thanks for working on this. https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/downloads_page/downloads_page.html File chrome/browser/resources/settings/downloads_page/downloads_page.html (left): https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/downloads_page/downloads_page.html#oldcode27 chrome/browser/resources/settings/downloads_page/downloads_page.html:27: $i18n{changeDownloadLocation} If this ...
3 years, 10 months ago (2017-02-01 23:06:23 UTC) #11
scottchen
https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html File chrome/browser/resources/settings/languages_page/edit_dictionary_page.html (right): https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html#newcode49 chrome/browser/resources/settings/languages_page/edit_dictionary_page.html:49: <div class="settings-box first block"> On 2017/02/01 23:06:23, dschuyler wrote: ...
3 years, 10 months ago (2017-02-02 01:17:14 UTC) #12
scottchen
On 2017/02/02 01:17:14, scottchen wrote: > https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html > File chrome/browser/resources/settings/languages_page/edit_dictionary_page.html > (right): > > https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html#newcode49 ...
3 years, 10 months ago (2017-02-02 01:24:17 UTC) #14
tommycli
lgtm from me (i didn't look at Dave's comments)
3 years, 10 months ago (2017-02-02 18:10:04 UTC) #19
dschuyler
https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode130 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:130: <span id="passwordExceptionsList" class="vertical-list"> On 2017/02/02 01:17:14, scottchen wrote: > ...
3 years, 10 months ago (2017-02-02 20:02:14 UTC) #20
scottchen
https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2668163002/diff/70001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode130 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:130: <span id="passwordExceptionsList" class="vertical-list"> On 2017/02/02 20:02:14, dschuyler wrote: > ...
3 years, 10 months ago (2017-02-02 20:31:41 UTC) #21
scottchen
https://codereview.chromium.org/2668163002/diff/170001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2668163002/diff/170001/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode144 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:144: <div id="noExceptionsLabel" class="list-item message-item" dschuyler@ I had to add ...
3 years, 10 months ago (2017-02-02 22:30:20 UTC) #22
dschuyler
lgtm Tommy, Scott, and I chatted offline and a new patch was put up.
3 years, 10 months ago (2017-02-02 23:00:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668163002/190001
3 years, 10 months ago (2017-02-02 23:18:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668163002/190001
3 years, 10 months ago (2017-02-03 01:42:27 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:09:47 UTC) #32
Message was sent while issue was closed.
Committed patchset #11 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/d8126246d566c209b04c3beb9a88...

Powered by Google App Engine
This is Rietveld 408576698