Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2668083003: Convert ExtensionActionRunner to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ExtensionActionRunner to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2668083003 Cr-Commit-Position: refs/heads/master@{#447532} Committed: https://chromium.googlesource.com/chromium/src/+/29737c4cebfbc36f45d26148a6b2a42f3d1c7069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/extensions/extension_action_runner.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_runner.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-01 15:31:23 UTC) #7
Devlin
lgtm
3 years, 10 months ago (2017-02-01 16:09:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668083003/1
3 years, 10 months ago (2017-02-01 16:19:42 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 16:26:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29737c4cebfbc36f45d26148a6b2...

Powered by Google App Engine
This is Rietveld 408576698