Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2668023004: [wasm] Change the default lowering of stores. (Closed)

Created:
3 years, 10 months ago by ahaas
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, rossberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Change the default lowering of stores. The int64-lowering only lowered store instructions with a word64 store representation. For all other stores the default lowering applied. The default lowering replaces all input nodes with both their replacement nodes, which can change the number of input nodes of the lowered node. In WebAssembly there exist stores which take an I64 input and store it with a different representation, e.g. I32. In TurboFan this translates to a store node with word32 store representation and a word64 value input. The default lowering replaces the word64 value input to become two word32 value inputs, which makes the number of inputs of the store node invalid. This CL discards the high word replacement of the value input so that the number of input nodes of a store node does not change in the default lowering. R=titzer@chromium.org CC=rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2668023004 Cr-Commit-Position: refs/heads/master@{#42860} Committed: https://chromium.googlesource.com/v8/v8/+/dd51dd926eff96e23b3022998f5a486f29860fac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M src/compiler/int64-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/int64-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 10 months ago (2017-02-01 15:18:19 UTC) #1
titzer
lgtm
3 years, 10 months ago (2017-02-01 15:31:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668023004/1
3 years, 10 months ago (2017-02-01 16:25:16 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 16:27:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dd51dd926eff96e23b3022998f5a486f298...

Powered by Google App Engine
This is Rietveld 408576698