Trivial simplification in JSObject::AddDataElement.

Trivial simplification in JSObject::AddDataElement.

Spotted by clang static analyzer, these variables are declared outside of
the condition but only used within.

Review-Url: https://codereview.chromium.org/2668003002
Cr-Commit-Position: refs/heads/master@{#42970}
Committed: https://chromium.googlesource.com/v8/v8/+/790518c13043ba0c83fa7cf9c240ed9f151bd1e3

[jbroman, 2017-01-31 15:49:28]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 15:49:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 16:16:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 16:16:08]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-02-02 19:39:48]

jbroman@chromium.org changed reviewers:
+ cbruni@chromium.org

[jbroman, 2017-02-02 19:39:49]

The clang static analyzer pointed this out. Totally trivial (maybe not even
worth landing), but I do find it a little easier to read with the
simplification.

[Camillo Bruni, 2017-02-06 14:28:11]

LGTM, nice!

This has probably potential for further optimization as NewNumberFromUint
creates an unecessary handle, especially in the case where length is in smi
range.

[jbroman, 2017-02-06 14:30:39]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-02-06 14:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 14:57:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486391439811450, "parent_rev":
"ae40e9683a4c42865213617d9c551c010c05b272", "commit_rev":
"790518c13043ba0c83fa7cf9c240ed9f151bd1e3"}

[commit-bot: I haz the power, 2017-02-06 14:57:45]

Description was changed from

==========
Trivial simplification in JSObject::AddDataElement.

Spotted by clang static analyzer, these variables are declared outside of
the condition but only used within.
==========

to

==========
Trivial simplification in JSObject::AddDataElement.

Spotted by clang static analyzer, these variables are declared outside of
the condition but only used within.

Review-Url: https://codereview.chromium.org/2668003002
Cr-Commit-Position: refs/heads/master@{#42970}
Committed:
https://chromium.googlesource.com/v8/v8/+/790518c13043ba0c83fa7cf9c240ed9f151...
==========

[commit-bot: I haz the power, 2017-02-06 14:57:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/790518c13043ba0c83fa7cf9c240ed9f151...