Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2667983002: Add test for expected source mappings (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -10 lines) Patch
M pkg/compiler/lib/src/io/position_information.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/annotated_code_helper.dart View 3 chunks +63 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/sourcemaps/mapping_test.dart View 1 chunk +216 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/stacktrace_test.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-01-31 15:24:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-01-31 21:46:56 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-01 09:00:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4358efc0ca7f313152c41657227a1d305a575085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698