Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: pkg/compiler/lib/src/io/position_information.dart

Issue 2667983002: Add test for expected source mappings (Closed)
Patch Set: Update comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/annotated_code_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/io/position_information.dart
diff --git a/pkg/compiler/lib/src/io/position_information.dart b/pkg/compiler/lib/src/io/position_information.dart
index 17e83978dd51fbd065e305e29977e4b029724188..2f67aa35e89bff1b8a122e1407a4423806d0119e 100644
--- a/pkg/compiler/lib/src/io/position_information.dart
+++ b/pkg/compiler/lib/src/io/position_information.dart
@@ -542,7 +542,9 @@ class PositionTraceListener extends TraceListener
switch (kind) {
case StepKind.FUN_ENTRY:
// TODO(johnniwinther): Remove this when fully transitioned to the
- // new source info system.
+ // new source info system. Verify that tools no longer expect JS
+ // function signatures to map to the origin. The main method may still
+ // need mapping to enable breakpoints before calling main.
registerPosition(SourcePositionKind.START);
break;
case StepKind.FUN_EXIT:
« no previous file with comments | « no previous file | tests/compiler/dart2js/annotated_code_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698