Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: ios/clean/chrome/browser/ui/tools/tools_coordinator.mm

Issue 2667873002: [ios clean] Remove stop on Browser coordinator dealloc (Closed)
Patch Set: Format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/clean/chrome/browser/ui/tools/tools_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm b/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm
index d80614efade9ba785b91fb331f4e7ef8259e022d..489008b9e33a3c092abfbe8af3ec71d06932506e 100644
--- a/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/tools/tools_coordinator.mm
@@ -38,9 +38,8 @@
}
- (void)stop {
- [self.menuViewController.presentingViewController
edchin 2017/01/31 07:18:26 At cursory glance, this seems right to me since it
- dismissViewControllerAnimated:self.context.animated
- completion:nil];
+ [self.menuViewController dismissViewControllerAnimated:self.context.animated
+ completion:nil];
edchin 2017/01/31 07:18:26 Can you explain how this fixes the corrupted state
}
#pragma mark - UIViewControllerTransitioningDelegate
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698