[ios clean] Remove stop on Browser coordinator dealloc

ios/clean/chrome/browser/ui/tools/tools_coordinator.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ======                        New Architecture                         =====
 // =         This code is only used in the new iOS Chrome architecture.       =
 // ============================================================================
 
 #import "ios/clean/chrome/browser/ui/tools/tools_coordinator.h"
 
@@ skipping 20 matching lines @@
   self.menuViewController = [[MenuViewController alloc] init];
   self.menuViewController.modalPresentationStyle = UIModalPresentationCustom;
   self.menuViewController.transitioningDelegate = self;
 
   [self.context.baseViewController presentViewController:self.menuViewController
                                                 animated:self.context.animated
                                               completion:nil];
 }
 
 - (void)stop {
-  [self.menuViewController.presentingViewController

[edchin, 2017/01/31 07:18:26]

At cursory glance, this seems right to me since it has symmetry in the start and
stop methods. I wonder if there is something else that is causing the corrupted
state?

-      dismissViewControllerAnimated:self.context.animated
-                         completion:nil];
+  [self.menuViewController dismissViewControllerAnimated:self.context.animated
+                                              completion:nil];

[edchin, 2017/01/31 07:18:26]

Can you explain how this fixes the corrupted state?

 }
 
 #pragma mark - UIViewControllerTransitioningDelegate
 
 - (id<UIViewControllerAnimatedTransitioning>)
 animationControllerForPresentedController:(UIViewController*)presented
                      presentingController:(UIViewController*)presenting
                          sourceController:(UIViewController*)source {
   ZoomTransitionAnimator* animator = [[ZoomTransitionAnimator alloc] init];
   animator.presenting = YES;
@@ skipping 15 matching lines @@
                             sourceViewController:(UIViewController*)source {
   MenuPresentationController* menuPresentation =
       [[MenuPresentationController alloc]
           initWithPresentedViewController:presented
                  presentingViewController:presenting];
   menuPresentation.toolbarCommandHandler = self.toolbarCommandHandler;
   return menuPresentation;
 }
 
 @end