Have SubframeLoadingDisabler singleton live off-heap.

Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=dcheng,haraken
BUG=684551
Review-Url: https://codereview.chromium.org/2667853006
Cr-Commit-Position: refs/heads/master@{#447682}
Committed: https://chromium.googlesource.com/chromium/src/+/05cea29b1f7245b2cbd42f7da77705b9fa820707

[sof, 2017-02-01 20:20:19]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:20:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-01 21:04:20]

Description was changed from

==========
Have SubframeLoadingDisabler singleton live off-heap.

Diagnose potential heap corruption.

R=
BUG=684551
==========

to

==========
Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=
BUG=684551
==========

[commit-bot: I haz the power, 2017-02-01 21:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:42:47]

Dry run: This issue passed the CQ dry run.

[sof, 2017-02-01 22:33:05]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[sof, 2017-02-01 22:33:05]

please take a look.

we need to understand what's going wrong on ToT, this isn't a solution but might
throw more light on how it enters.

[dcheng, 2017-02-01 22:37:44]

LGTM

[haraken, 2017-02-01 22:38:26]

On 2017/02/01 22:33:05, sof wrote:
> please take a look.
> 
> we need to understand what's going wrong on ToT, this isn't a solution but
might
> throw more light on how it enters.

LGTM. Shall we add a comment to explain that?

[sof, 2017-02-01 23:52:01]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:52:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-01 23:53:14]

On 2017/02/01 22:38:26, haraken wrote:
> On 2017/02/01 22:33:05, sof wrote:
> > please take a look.
> > 
> > we need to understand what's going wrong on ToT, this isn't a solution but
> might
> > throw more light on how it enters.
> 
> LGTM. Shall we add a comment to explain that?

Yes, UntracedMember<> uses are preferably comment-clarified. done.

[sof, 2017-02-01 23:53:31]

Description was changed from

==========
Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=
BUG=684551
==========

to

==========
Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=dcheng,haraken
BUG=684551
==========

[commit-bot: I haz the power, 2017-02-02 01:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 01:47:22]

Dry run: This issue passed the CQ dry run.

[sof, 2017-02-02 01:47:47]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2017-02-02 01:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2667853006/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2017-02-02 01:48:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:56:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486000067477670,
"parent_rev": "c58f0323797ee837ccc917c8e31886a0fcbf712e", "commit_rev":
"05cea29b1f7245b2cbd42f7da77705b9fa820707"}

[commit-bot: I haz the power, 2017-02-02 01:57:06]

Description was changed from

==========
Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=dcheng,haraken
BUG=684551
==========

to

==========
Have SubframeLoadingDisabler singleton live off-heap.

Primarily to diagnose potential heap corruption, keep
track of the disabled set off-heap. The untraced references
added aren't unsafe, as they are all stack-reachable by
construction.

R=dcheng,haraken
BUG=684551

Review-Url: https://codereview.chromium.org/2667853006
Cr-Commit-Position: refs/heads/master@{#447682}
Committed:
https://chromium.googlesource.com/chromium/src/+/05cea29b1f7245b2cbd42f7da777...
==========

[commit-bot: I haz the power, 2017-02-02 01:57:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05cea29b1f7245b2cbd42f7da777...