Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2667843007: Revert a behavioral change in AudioManagerWin::GetInputStreamParameters. (Closed)

Created:
3 years, 10 months ago by tommi (sloooow) - chröme
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, olka, DaleCurtis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert a behavioral change in AudioManagerWin::GetInputStreamParameters. This CL reverts a part of a change landed last week: https://codereview.chromium.org/2646423005 From the canary data it looks like some code paths still depend on the previous behavior. BUG=684741 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2667843007 Cr-Commit-Position: refs/heads/master@{#447518} Committed: https://chromium.googlesource.com/chromium/src/+/9647273a0f14390552564183f519635cf5f6f1f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M media/audio/win/audio_manager_win.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tommi (sloooow) - chröme
3 years, 10 months ago (2017-02-01 12:14:57 UTC) #3
henrika (OOO until Aug 14)
lgtm
3 years, 10 months ago (2017-02-01 12:18:22 UTC) #6
Max Morin
lgtm
3 years, 10 months ago (2017-02-01 12:20:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667843007/1
3 years, 10 months ago (2017-02-01 15:48:01 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 15:52:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9647273a0f14390552564183f519...

Powered by Google App Engine
This is Rietveld 408576698