Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2667843004: DevTools: rebaseline console tests (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, luoe
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rebaseline console tests Set console filter level for tests to debug level by default. BUG=682078 Review-Url: https://codereview.chromium.org/2667843004 Cr-Commit-Position: refs/heads/master@{#447668} Committed: https://chromium.googlesource.com/chromium/src/+/09a6a441c91c5a52650c315cc915fe461e58cb33

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove option to customize level #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -401 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/command-line-api-getEventListeners-expected.txt View 12 chunks +0 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-big-array-expected.txt View 7 chunks +13 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-clear-function-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-command-clear-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-dir-es6-expected.txt View 6 chunks +22 lines, -22 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-edit-property-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-error-on-call-frame-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-external-array-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-filter-level-test-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-collections-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-es6-2-expected.txt View 6 chunks +40 lines, -40 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-es6-expected.txt View 3 chunks +92 lines, -92 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-expected.txt View 20 chunks +149 lines, -149 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-log-before-inspector-open-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-log-object-with-getter-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-log-side-effects-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-log-without-console-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-object-preview-expected.txt View 2 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-on-paint-worklet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-save-to-temp-var-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-tainted-globals-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-tests-expected.txt View 2 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-uncaught-promise-in-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-worker-nested-imports-syntax-error-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
chenwilliam
ptal https://codereview.chromium.org/2667843004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js (right): https://codereview.chromium.org/2667843004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js#newcode96 third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js:96: Common.settingForTest('messageLevelFilters2').set(level || SDK.ConsoleMessage.MessageLevel.Verbose); This was needed for inspector/console/console.time.html ...
3 years, 10 months ago (2017-01-31 22:28:37 UTC) #3
luoe
lgtm Could you also put the command you used to generate these baselines in the ...
3 years, 10 months ago (2017-02-01 02:39:04 UTC) #4
chenwilliam
dgozman@chromium.org: ptal. https://codereview.chromium.org/2667843004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js (right): https://codereview.chromium.org/2667843004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js#newcode96 third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js:96: Common.settingForTest('messageLevelFilters2').set(level || SDK.ConsoleMessage.MessageLevel.Verbose); On 2017/02/01 at 02:39:04, ...
3 years, 10 months ago (2017-02-01 23:43:44 UTC) #6
chenwilliam
dgozman@chromium.org: ptal.
3 years, 10 months ago (2017-02-01 23:43:44 UTC) #8
dgozman
lgtm
3 years, 10 months ago (2017-02-01 23:53:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667843004/20001
3 years, 10 months ago (2017-02-01 23:55:31 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:14:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09a6a441c91c5a52650c315cc915...

Powered by Google App Engine
This is Rietveld 408576698