Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2667823004: Merged: [inspector] introduced memory size limit for console message storage (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Yang, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [inspector] introduced memory size limit for console message storage Revision: 3903817e0eead8f9812ee0e5481379190bfa3410 BUG=chromium:671489 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=kozyatinskiy@chromium.org Review-Url: https://codereview.chromium.org/2667823004 . Cr-Commit-Position: refs/branch-heads/5.7@{#82} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/dd9817937f5e41828d727158f2b968b03946e0b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -9 lines) Patch
M src/api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/v8-console-message.h View 4 chunks +6 lines, -2 lines 0 comments Download
M src/inspector/v8-console-message.cc View 6 chunks +23 lines, -7 lines 0 comments Download
A test/inspector/runtime/console-messages-limits.js View 1 chunk +44 lines, -0 lines 0 comments Download
A test/inspector/runtime/console-messages-limits-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kozy
3 years, 10 months ago (2017-02-01 16:54:17 UTC) #1
kozy
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-01 16:54:18 UTC) #2
kozy
lgtm
3 years, 10 months ago (2017-02-01 16:55:44 UTC) #3
kozy
3 years, 10 months ago (2017-02-01 16:56:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd9817937f5e41828d727158f2b968b03946e0b6.

Powered by Google App Engine
This is Rietveld 408576698