Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2667763004: DevTools: add sticky position to CSS completions (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add sticky position to CSS completions BUG=686491 R=dgozman_slow Review-Url: https://codereview.chromium.org/2667763004 Cr-Commit-Position: refs/heads/master@{#447208} Committed: https://chromium.googlesource.com/chromium/src/+/9bacf8a7a7c988286a11b9fea97c61f848b4b4a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
lushnikov
please, take a look
3 years, 10 months ago (2017-01-31 05:22:20 UTC) #1
dgozman
lgtm
3 years, 10 months ago (2017-01-31 06:09:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667763004/1
3 years, 10 months ago (2017-01-31 06:13:14 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 08:57:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9bacf8a7a7c988286a11b9fea97c...

Powered by Google App Engine
This is Rietveld 408576698