Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2667763003: Pass camera facing to WebKit (Closed)

Created:
3 years, 10 months ago by wuchengli
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Pass camera facing to WebKit We want to expose camera facing information in JS API. First step is to pass it to MediaStreamVideoTrack::getSettings(). BUG=webrtc:2481, 543997, 684375 TEST=Log the camera facing value in VideoCaptureImplManager Review-Url: https://codereview.chromium.org/2609863004 Cr-Commit-Position: refs/heads/master@{#445663} (cherry picked from commit 5466f424bef9d4997ff78783f9bb2ec4acbbabcc) Review-Url: https://codereview.chromium.org/2667763003 . Cr-Commit-Position: refs/branch-heads/2987@{#212} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/09d60fcf9d6f8b85a5172e39befb50b617ef40bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -48 lines) Patch
M content/common/media/media_stream_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/media_stream_request.h View 4 chunks +7 lines, -10 lines 0 comments Download
M content/public/common/media_stream_request.cc View 2 chunks +14 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 2 chunks +4 lines, -3 lines 0 comments Download
A media/base/video_facing.h View 1 chunk +21 lines, -0 lines 0 comments Download
M media/capture/video/linux/camera_facing_chromeos.h View 4 chunks +7 lines, -8 lines 0 comments Download
M media/capture/video/linux/camera_facing_chromeos.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M media/capture/video/linux/camera_facing_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_factory_linux.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M media/capture/video/video_capture_device_descriptor.h View 3 chunks +11 lines, -6 lines 0 comments Download
M media/capture/video/video_capture_device_descriptor.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
3 years, 10 months ago (2017-01-31 02:58:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09d60fcf9d6f8b85a5172e39befb50b617ef40bd.

Powered by Google App Engine
This is Rietveld 408576698