Divide Cookie Store IOS tests into different files

Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid code 
replication, helper methods and classes are put to 
cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
Review-Url: https://codereview.chromium.org/2667753007
Cr-Commit-Position: refs/heads/master@{#447783}
Committed: https://chromium.googlesource.com/chromium/src/+/e209771cd1fcaeef978eabe82eaa03297c33b50e

[maksims (do not use this acc), 2017-02-01 12:47:13]

Description was changed from

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL that split cookie_store_ios_unittest into two
different files with different backends. In order to avoid cody replication,
helper methods and classes are put to cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
==========

to

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid cody replication,
helper methods and classes are put to cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
==========

[maksims (do not use this acc), 2017-02-01 12:47:26]

Description was changed from

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid cody replication,
helper methods and classes are put to cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
==========

to

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid code 
replication, helper methods and classes are put to 
cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
==========

[maksims (do not use this acc), 2017-02-01 12:50:16]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 12:50:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2017-02-01 12:57:32]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 12:57:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2017-02-01 12:58:21]

maksim.sisov@intel.com changed reviewers:
+ eugenebut@chromium.org

[maksims (do not use this acc), 2017-02-01 12:58:36]

please review

[commit-bot: I haz the power, 2017-02-01 13:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 13:58:16]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-01 17:35:55]

Thank you for doing this!

https://codereview.chromium.org/2667753007/diff/20001/ios/net/BUILD.gn
File ios/net/BUILD.gn (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/BUILD.gn#newcode84
ios/net/BUILD.gn:84: "cookies/cookie_store_ios_unittest_helper.h",
Should this be cookie_store_ios_test_util? I feel this is more common name.

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios_persistent_unittest.mm (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_persistent_unittest.mm:49: class
NotSynchronizedCookieStoreIOSWithBackend : public testing::Test {
How about
s/NotSynchronizedCookieStoreIOSWithBackend/CookieStoreIOSPersistentTest ?

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_persistent_unittest.mm:53: backend_(new
net::TestPersistentCookieStore),
Could you please use base::MakeUnique here as well

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_unittest.mm:80: class
SynchronizedCookieStoreIOS : public testing::Test {
How about s/SynchronizedCookieStoreIOS/CookieStoreIOSTest ?

[maksims (do not use this acc), 2017-02-02 05:41:44]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 05:42:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 05:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 05:49:25]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[maksims (do not use this acc), 2017-02-02 05:56:39]

Patchset #3 (id:40001) has been deleted

[maksims (do not use this acc), 2017-02-02 05:56:54]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 05:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2017-02-02 06:47:04]

https://codereview.chromium.org/2667753007/diff/20001/ios/net/BUILD.gn
File ios/net/BUILD.gn (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/BUILD.gn#newcode84
ios/net/BUILD.gn:84: "cookies/cookie_store_ios_unittest_helper.h",
On 2017/02/01 17:35:54, Eugene But wrote:
> Should this be cookie_store_ios_test_util? I feel this is more common name.

Done.

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios_persistent_unittest.mm (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_persistent_unittest.mm:49: class
NotSynchronizedCookieStoreIOSWithBackend : public testing::Test {
On 2017/02/01 17:35:54, Eugene But wrote:
> How about
> s/NotSynchronizedCookieStoreIOSWithBackend/CookieStoreIOSPersistentTest ?

Done.

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_persistent_unittest.mm:53: backend_(new
net::TestPersistentCookieStore),
On 2017/02/01 17:35:54, Eugene But wrote:
> Could you please use base::MakeUnique here as well

|backend_| is scoped_refptr

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios_unittest.mm (right):

https://codereview.chromium.org/2667753007/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios_unittest.mm:80: class
SynchronizedCookieStoreIOS : public testing::Test {
On 2017/02/01 17:35:54, Eugene But wrote:
> How about s/SynchronizedCookieStoreIOS/CookieStoreIOSTest ?

Done.

[commit-bot: I haz the power, 2017-02-02 07:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 07:19:20]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-02 16:46:37]

Thank you! lgtm

[maksims (do not use this acc), 2017-02-02 17:05:08]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2017-02-02 17:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 17:10:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486055108813970,
"parent_rev": "f2774bfe725f433421242e887269aa093bfe405a", "commit_rev":
"e209771cd1fcaeef978eabe82eaa03297c33b50e"}

[commit-bot: I haz the power, 2017-02-02 17:10:57]

Description was changed from

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid code 
replication, helper methods and classes are put to 
cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736
==========

to

==========
Divide Cookie Store IOS tests into different files

This is a follow-up CL, which splits cookie_store_ios_unittest into two
different files with different backends. In order to avoid code 
replication, helper methods and classes are put to 
cookie_store_ios_unittest_helper.*

Main CL - https://codereview.chromium.org/2649083002/

BUG=679736

Review-Url: https://codereview.chromium.org/2667753007
Cr-Commit-Position: refs/heads/master@{#447783}
Committed:
https://chromium.googlesource.com/chromium/src/+/e209771cd1fcaeef978eabe82eaa...
==========

[commit-bot: I haz the power, 2017-02-02 17:10:58]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e209771cd1fcaeef978eabe82eaa...