Make new target for vector icon structs to replace ui/gfx/vector_icons/

ui/vector_icons/vector_icons.h.template

Index: ui/vector_icons/vector_icons.h.template
diff --git a/ui/vector_icons/vector_icons.h.template b/ui/vector_icons/vector_icons.h.template
new file mode 100644
index 0000000000000000000000000000000000000000..9b8861c2ce34081b0db13aad44c53198e23e66c9
--- /dev/null
+++ b/ui/vector_icons/vector_icons.h.template
@@ -0,0 +1,26 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// vector_icons.h.template is used to generate vector_icons.h. Edit the former
+// rather than the latter.
+
+#ifndef UI_VECTOR_ICONS_VECTOR_ICONS_H_
+#define UI_VECTOR_ICONS_VECTOR_ICONS_H_
+
+namespace gfx {
+struct VectorIcon;
+}
+
+#define VECTOR_ICON_TEMPLATE_H(icon_name) \
+extern const gfx::VectorIcon icon_name;

[sky, 2017/02/03 16:20:06]

Don't you need to export there?

[Evan Stade, 2017/02/03 18:35:01]

I would have thought so, but I believe that only applies to components (this is
a shared library).

"""
If your code is not being compiled into a component, don’t define such a macro
(sometimes people do this by copying other targets without understanding).
"""
https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md

There is test coverage for this --- dbg windows trybots would have complained if
it needed an export.

+
+namespace ui {
+
+TEMPLATE_PLACEHOLDER
+
+}  // namespace ui
+
+#undef VECTOR_ICON_TEMPLATE_H
+
+#endif  // UI_VECTOR_ICONS_VECTOR_ICONS_H_