ui/vector_icons/vector_icons.h.template - Issue 2667753006: Make new target for vector icon structs to replace ui/gfx/vector_icons/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/vector_icons/vector_icons.h.template

Issue 2667753006: Make new target for vector icon structs to replace ui/gfx/vector_icons/ (Closed)

Patch Set: git add again Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // vector_icons.h.template is used to generate vector_icons.h. Edit the former

	6 // rather than the latter.

	7

	8 #ifndef UI_VECTOR_ICONS_VECTOR_ICONS_H_

	9 #define UI_VECTOR_ICONS_VECTOR_ICONS_H_

	10

	11 namespace gfx {

	12 struct VectorIcon;

	13 }

	14

	15 #define VECTOR_ICON_TEMPLATE_H(icon_name) \

	16 extern const gfx::VectorIcon icon_name;
	sky 2017/02/03 16:20:06 Don't you need to export there? Don't you need to export there? Evan Stade 2017/02/03 18:35:01 I would have thought so, but I believe that only a Show quoted text On 2017/02/03 16:20:06, sky wrote: > Don't you need to export there? I would have thought so, but I believe that only applies to components (this is a shared library). """ If your code is not being compiled into a component, don’t define such a macro (sometimes people do this by copying other targets without understanding). """ https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md There is test coverage for this --- dbg windows trybots would have complained if it needed an export.
	17

	18 namespace ui {

	19

	20 TEMPLATE_PLACEHOLDER

	21

	22 } // namespace ui

	23

	24 #undef VECTOR_ICON_TEMPLATE_H

	25

	26 #endif // UI_VECTOR_ICONS_VECTOR_ICONS_H_

OLD	NEW