Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2667723002: Make static initialization threadsafe by default (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make static initialization threadsafe by default Example of followups required here: https://codereview.chromium.org/2667513003/. BUG=686866, 587210, 686730, crashpad:141 Review-Url: https://codereview.chromium.org/2667723002 Cr-Commit-Position: refs/heads/master@{#447163} Committed: https://chromium.googlesource.com/chromium/src/+/da667f7e960637d2531cf0306fbc2137633e1773

Patch Set 1 #

Messages

Total messages: 16 (12 generated)
scottmg
Android bots are timing out after 2h of compile, but I think it's generally OK.
3 years, 10 months ago (2017-01-30 23:45:59 UTC) #6
Mark Mentovai
LGTM! I’ve wanted this for a long, long time. Basically since the beginning of Chrome.
3 years, 10 months ago (2017-01-31 00:35:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667723002/1
3 years, 10 months ago (2017-01-31 00:41:16 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 02:15:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da667f7e960637d2531cf0306fbc...

Powered by Google App Engine
This is Rietveld 408576698