Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2667713002: Settings: Network icons need to be flex (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Network icons need to be flex BUG=686617 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667713002 Cr-Commit-Position: refs/heads/master@{#447130} Committed: https://chromium.googlesource.com/chromium/src/+/808a1143dc33f3bd0555c7ac48322fb7d6c06c13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/webui/resources/cr_elements/network/cr_network_icon.html View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
I accidentally broke this when we switched the icons to SVG.
3 years, 10 months ago (2017-01-30 20:37:35 UTC) #3
Dan Beam
ouch lgtm
3 years, 10 months ago (2017-01-30 22:05:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667713002/1
3 years, 10 months ago (2017-01-30 23:10:03 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:31:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/808a1143dc33f3bd0555c7ac4832...

Powered by Google App Engine
This is Rietveld 408576698