Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2667643002: Revert of Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
Reviewers:
foolip
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) (patchset #1 id:1 of https://codereview.chromium.org/2627973002/ ) Reason for revert: Suspect CL causing failures has been reverted (https://codereview.chromium.org/2665663003/) Original issue's description: > Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky) > > BUG=679949 > TBR=dominickn@chromium.org > > Review-Url: https://codereview.chromium.org/2627973002 . > Cr-Commit-Position: refs/heads/master@{#442913} > Committed: https://chromium.googlesource.com/chromium/src/+/09a3924243cd62fd49cc091b6948f1455963f851 TBR=foolip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=679949 Review-Url: https://codereview.chromium.org/2667643002 Cr-Commit-Position: refs/heads/master@{#447028} Committed: https://chromium.googlesource.com/chromium/src/+/c336037815019df68c431a22870ce4c122a8ddca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dominickn
Created Revert of Disable testBannerAppearsThenDoesNotAppearAgainForCustomTime (flaky)
3 years, 10 months ago (2017-01-30 18:34:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667643002/1
3 years, 10 months ago (2017-01-30 18:34:59 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:15:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c336037815019df68c431a22870c...

Powered by Google App Engine
This is Rietveld 408576698