Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2667553002: Move API for field trial params to base from variations. (Closed)

Created:
3 years, 10 months ago by Alexei Svitkine (slow)
Modified:
3 years, 10 months ago
Reviewers:
gab, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move API for field trial params to base from variations. Now that the underlying implementation also works in sub-processes, this CL moves the APIs to base (naming the field trial params), so that they can be easily accessed by all Chrome sub-processes. Marks the existing variation params APIs as deprecated. Existing callers can be migrates via future CLs and these can then be removed. Unit tests also moved to base. BUG=681160 Review-Url: https://codereview.chromium.org/2667553002 Cr-Commit-Position: refs/heads/master@{#447108} Committed: https://chromium.googlesource.com/chromium/src/+/79ab08c0137f5485173e8de5cd28201774ce1a0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -1082 lines) Patch
M base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + base/metrics/field_trial_params.h View 1 chunk +65 lines, -176 lines 0 comments Download
A + base/metrics/field_trial_params.cc View 8 chunks +31 lines, -184 lines 0 comments Download
A + base/metrics/field_trial_params_unittest.cc View 4 chunks +148 lines, -316 lines 0 comments Download
M components/variations/variations_associated_data.h View 1 chunk +8 lines, -49 lines 0 comments Download
M components/variations/variations_associated_data.cc View 2 chunks +12 lines, -72 lines 0 comments Download
M components/variations/variations_associated_data_unittest.cc View 3 chunks +0 lines, -285 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
Alexei Svitkine (slow)
3 years, 10 months ago (2017-01-30 07:59:23 UTC) #10
rkaplow
lgtm
3 years, 10 months ago (2017-01-30 22:09:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667553002/120001
3 years, 10 months ago (2017-01-30 22:10:01 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/353448)
3 years, 10 months ago (2017-01-30 22:21:35 UTC) #19
Alexei Svitkine (slow)
+gab for base/ owners
3 years, 10 months ago (2017-01-30 22:23:56 UTC) #21
Alexei Svitkine (slow)
gab: just need an owners approval for base/BUILD.gn since I'm owner of base/metrics Thanks!
3 years, 10 months ago (2017-01-30 22:24:29 UTC) #22
gab
On 2017/01/30 22:24:29, Alexei Svitkine (very slow) wrote: > gab: just need an owners approval ...
3 years, 10 months ago (2017-01-30 23:08:59 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667553002/120001
3 years, 10 months ago (2017-01-30 23:21:54 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 23:27:46 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/79ab08c0137f5485173e8de5cd28...

Powered by Google App Engine
This is Rietveld 408576698