Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2667513002:
DevTools: Missing parenthesis on url in NetworkLog (Closed)
|
Created:
3 years, 10 months ago by einbinder Modified:
3 years, 10 months ago CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src/third_party/WebKit/Source/devtools@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Missing parenthesis on url in NetworkLog
BUG=689132
Review-Url: https://codereview.chromium.org/2667513002
Cr-Commit-Position: refs/heads/master@{#448396}
Committed: https://chromium.googlesource.com/chromium/src/+/6004f9b3a66dce2ad170a521529d3414e26fb538
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
einbinder@chromium.org changed reviewers: + dgozman@chromium.org
ptal
Description was changed from ========== DevTools: Missing parenthesis on url in NetworkLog BUG=none ========== to ========== DevTools: Missing parenthesis on url in NetworkLog BUG=none ==========
pfeldman@chromium.org changed reviewers: + allada@chromium.org
On 2017/01/30 16:23:38, einbinder wrote: > ptal We need to file a bug and get it merged.
lgtm. Here's the original bug: http://crbug.com/679105 It'll need to be merged onto: 2987 (dev - or soon-to-be beta)
you need a new bug just to merge, should mention that this was a regression.
Description was changed from ========== DevTools: Missing parenthesis on url in NetworkLog BUG=none ========== to ========== DevTools: Missing parenthesis on url in NetworkLog BUG=689132 ==========
The CQ bit was checked by einbinder@chromium.org
ptal
The CQ bit was unchecked by einbinder@chromium.org
The CQ bit was checked by einbinder@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
pfeldman@chromium.org changed reviewers: + pfeldman@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486416217316130, "parent_rev":
"c9e6676225dad6039deae8bd37167d75edd093db", "commit_rev":
"6004f9b3a66dce2ad170a521529d3414e26fb538"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Missing parenthesis on url in NetworkLog BUG=689132 ========== to ========== DevTools: Missing parenthesis on url in NetworkLog BUG=689132 Review-Url: https://codereview.chromium.org/2667513002 Cr-Commit-Position: refs/heads/master@{#448396} Committed: https://chromium.googlesource.com/chromium/src/+/6004f9b3a66dce2ad170a521529d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6004f9b3a66dce2ad170a521529d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
