Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2667453003: [turbofan] Remove escape analysis stats counters. (Closed)

Created:
3 years, 10 months ago by Michael Starzinger
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove escape analysis stats counters. These counters were used during the initial implementation to gather statistics about comparative effectiveness of the two escape analysis approaches in practice. The counters are not thread-safe and cannot be used for the analysis any longer as it is now running off main thread. We deprecate the counters in question in favor of maintaining deferred statistics until the need for such statistics arises again. R=bmeurer@chromium.org BUG=chromium:685942 Review-Url: https://codereview.chromium.org/2667453003 Cr-Commit-Position: refs/heads/master@{#42808} Committed: https://chromium.googlesource.com/v8/v8/+/418c9eca799530ab19b9dd2d0eb24278669945b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M src/compiler/escape-analysis-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen-escape-analysis.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Starzinger
3 years, 10 months ago (2017-01-30 14:59:39 UTC) #4
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-01-30 17:37:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667453003/1
3 years, 10 months ago (2017-01-31 08:50:20 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 08:52:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/418c9eca799530ab19b9dd2d0eb24278669...

Powered by Google App Engine
This is Rietveld 408576698