blink: Remove include ordering checks, clang-format does this now.

blink: Remove include ordering checks, clang-format does this now.

One change in behavior: clang-format wants <> includes to go first
(like in Chromium -- but Chromium style recommends a newline between the
<> include block and the "" include block), while they used to go to the
end in Blink.

BUG=688155
Review-Url: https://codereview.chromium.org/2667423006
Cr-Commit-Position: refs/heads/master@{#448074}
Committed: https://chromium.googlesource.com/chromium/src/+/9f3583163a9592f26a0b72ff702eee5d9b5f0378

[Nico, 2017-02-03 18:08:25]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-02-03 18:08:50]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-03 18:15:59]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 18:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-03 18:16:18]

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2512: # Qt
private APIs use _p.h suffix.
Nit: remove this as well

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2520: if include
== "ResourceHandleWin.h":
Maybe this too?

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2620: '%s Should
be: alphabetically sorted.' %
What's the path for emitting this error now? I can't easily tell if this is dead
or not.

[Nico, 2017-02-03 18:20:38]

Thanks!

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2512: # Qt
private APIs use _p.h suffix.
On 2017/02/03 18:16:18, dcheng wrote:
> Nit: remove this as well

Done.

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2520: if include
== "ResourceHandleWin.h":
On 2017/02/03 18:16:18, dcheng wrote:
> Maybe this too?

sure, done

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2620: '%s Should
be: alphabetically sorted.' %
On 2017/02/03 18:16:18, dcheng wrote:
> What's the path for emitting this error now? I can't easily tell if this is
dead
> or not.

test_check_next_include_order__no_self reaches it

[Nico, 2017-02-03 18:38:51]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 18:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-03 18:53:50]

LGTM

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py (right):

https://codereview.chromium.org/2667423006/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:2620: '%s Should
be: alphabetically sorted.' %
On 2017/02/03 18:20:38, Nico wrote:
> On 2017/02/03 18:16:18, dcheng wrote:
> > What's the path for emitting this error now? I can't easily tell if this is
> dead
> > or not.
> 
> test_check_next_include_order__no_self reaches it

Hmm. The "should be: alphabetically sorted" thing seem to be a bit of red
herring now then, so it might be nice to get rid of that.

[commit-bot: I haz the power, 2017-02-03 19:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:44:54]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-03 21:14:20]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-02-03 21:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 21:36:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486156460455350,
"parent_rev": "3b68263961bca6f4d43ca1ad3ecced5a6c31cc74", "commit_rev":
"9f3583163a9592f26a0b72ff702eee5d9b5f0378"}

[commit-bot: I haz the power, 2017-02-03 21:37:34]

Description was changed from

==========
blink: Remove include ordering checks, clang-format does this now.

One change in behavior: clang-format wants <> includes to go first
(like in Chromium -- but Chromium style recommends a newline between the
<> include block and the "" include block), while they used to go to the
end in Blink.

BUG=688155
==========

to

==========
blink: Remove include ordering checks, clang-format does this now.

One change in behavior: clang-format wants <> includes to go first
(like in Chromium -- but Chromium style recommends a newline between the
<> include block and the "" include block), while they used to go to the
end in Blink.

BUG=688155

Review-Url: https://codereview.chromium.org/2667423006
Cr-Commit-Position: refs/heads/master@{#448074}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f3583163a9592f26a0b72ff702e...
==========

[commit-bot: I haz the power, 2017-02-03 21:37:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f3583163a9592f26a0b72ff702e...