Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2667403003: Upstream a couple of IndexedDB layout tests to WPT. (Closed)

Created:
3 years, 10 months ago by pwnall
Modified:
3 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, jsbell+idb_chromium.org, cmumford, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream a couple of IndexedDB layout tests to WPT. Blink's deleteDatabase-event.html overlaps a lot with WPT's idbversionchangeevent.htm, so this CL extends the WPT test such that it covers a superset of Blink's test. BUG=683463 Review-Url: https://codereview.chromium.org/2667403003 Cr-Commit-Position: refs/heads/master@{#448787} Committed: https://chromium.googlesource.com/chromium/src/+/5828b07613ab92a7b0b5a51bb12555f2e03b5e2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -197 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/IndexedDB/clone-before-keypath-eval.html View 1 chunk +135 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbversionchangeevent.htm View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 3 chunks +11 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/clone-before-keypath-eval.html View 1 chunk +0 lines, -146 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/deleteDatabase-event.html View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pwnall
PTAL?
3 years, 10 months ago (2017-02-02 23:01:16 UTC) #4
jsbell
lgtm
3 years, 10 months ago (2017-02-07 21:55:42 UTC) #7
pwnall
On 2017/02/07 21:55:42, jsbell wrote: > lgtm Thank you very much!
3 years, 10 months ago (2017-02-07 22:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667403003/1
3 years, 10 months ago (2017-02-07 22:30:05 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:35:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5828b07613ab92a7b0b5a51bb125...

Powered by Google App Engine
This is Rietveld 408576698