Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2667203002: s390: fix ri-c format for brc (Closed)

Created:
3 years, 10 months ago by john.yan
Modified:
3 years, 10 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: fix ri-c format for brc R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2667203002 Cr-Commit-Position: refs/heads/master@{#42869} Committed: https://chromium.googlesource.com/v8/v8/+/5b000593c964efc8502aca30515adbfc2a401294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/s390/assembler-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
john.yan
ptal
3 years, 10 months ago (2017-02-01 19:30:47 UTC) #1
JaideepBajwa
lgtm
3 years, 10 months ago (2017-02-01 19:34:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667203002/1
3 years, 10 months ago (2017-02-01 19:43:48 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-01 19:43:50 UTC) #6
JoranSiu
On 2017/02/01 19:43:50, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-01 20:20:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667203002/1
3 years, 10 months ago (2017-02-01 20:22:46 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:32:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5b000593c964efc8502aca30515adbfc2a4...

Powered by Google App Engine
This is Rietveld 408576698