Convert BiquadFilter getFrequencyResponse and tail test to testharness

Convert BiquadFilter getFrequencyResponse and tail test to testharness

Manually converted testd to use testharness and new Audit.

BUG=687307
TEST=biquad-getFrequencyResponse.html, biquad-tail.html

Review-Url: https://codereview.chromium.org/2667173002
Cr-Commit-Position: refs/heads/master@{#448334}
Committed: https://chromium.googlesource.com/chromium/src/+/01322c63452743495ef7b483540ee57efcb7698a

[Raymond Toy, 2017-02-01 18:10:31]

Description was changed from

==========
Convert BiquadFilter getFrequencyResponse and tail test to testharness

Manually converted test to use testharness and new Audit.

Although, biquad-tail was already using old Audit, converting to new
Audit was a one-line change, so it was converted to use new Audit.

BUG=687307
TEST=biquad-getFrequencyResponse.html, biquad-tail.html
==========

to

==========
Convert BiquadFilter getFrequencyResponse and tail test to testharness

Manually converted testd to use testharness and new Audit.

BUG=687307
TEST=biquad-getFrequencyResponse.html, biquad-tail.html
==========

[Raymond Toy, 2017-02-01 18:13:46]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-01 18:13:47]

PTAL.

[hongchan, 2017-02-02 19:41:01]

biquad-getFrequencyResponse.html has many anti-patterns, but that's not the
issue here.

|success| is not being updated in the changed code. Is that really equivalent to
the previous code?

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
(right):

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:193:
.beEqualTo(0);
Where is |success| now?

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:270:
var success = compareResponses(should, filter, frequencies, magResponse,
phaseResponse);
|success| is not being used anywhere.

[Raymond Toy, 2017-02-03 16:16:38]

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
(right):

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:193:
.beEqualTo(0);
On 2017/02/02 19:41:01, hongchan wrote:
> Where is |success| now?

Not used anywhere, so I'm removing it, including the return.

https://codereview.chromium.org/2667173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:270:
var success = compareResponses(should, filter, frequencies, magResponse,
phaseResponse);
On 2017/02/02 19:41:01, hongchan wrote:
> |success| is not being used anywhere.

Not needed anymore and compareResponses no longer returns anything.

[hongchan, 2017-02-06 17:36:58]

lgtm with nits

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
(right):

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:225:
"Max error (" + linearToDecibels(maxMagError) + " dB) of magnitude response at
frequency " + frequencies[maxMagErrorIndex] + " Hz")
New code over 80 cols. Needs to be wrapped.

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:240:
"Max error (" + radToDegree(maxPhaseError) + " deg) in phase response at
frequency " + frequencies[maxPhaseErrorIndex] + " Hz")
Ditto.

[Raymond Toy, 2017-02-06 17:54:13]

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
(right):

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:225:
"Max error (" + linearToDecibels(maxMagError) + " dB) of magnitude response at
frequency " + frequencies[maxMagErrorIndex] + " Hz")
On 2017/02/06 17:36:58, hongchan wrote:
> New code over 80 cols. Needs to be wrapped.

Done.

https://codereview.chromium.org/2667173002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html:240:
"Max error (" + radToDegree(maxPhaseError) + " deg) in phase response at
frequency " + frequencies[maxPhaseErrorIndex] + " Hz")
On 2017/02/06 17:36:58, hongchan wrote:
> Ditto.

Done.

[Raymond Toy, 2017-02-06 17:54:19]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-06 17:54:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2667173002/#ps60001
(title: "Address nits")

[commit-bot: I haz the power, 2017-02-06 17:54:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:08:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486403659692080,
"parent_rev": "58fbeca88c6fe663238eacd82c8943cafb304df3", "commit_rev":
"01322c63452743495ef7b483540ee57efcb7698a"}

[commit-bot: I haz the power, 2017-02-06 19:09:00]

Description was changed from

==========
Convert BiquadFilter getFrequencyResponse and tail test to testharness

Manually converted testd to use testharness and new Audit.

BUG=687307
TEST=biquad-getFrequencyResponse.html, biquad-tail.html
==========

to

==========
Convert BiquadFilter getFrequencyResponse and tail test to testharness

Manually converted testd to use testharness and new Audit.

BUG=687307
TEST=biquad-getFrequencyResponse.html, biquad-tail.html

Review-Url: https://codereview.chromium.org/2667173002
Cr-Commit-Position: refs/heads/master@{#448334}
Committed:
https://chromium.googlesource.com/chromium/src/+/01322c63452743495ef7b483540e...
==========

[commit-bot: I haz the power, 2017-02-06 19:09:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/01322c63452743495ef7b483540e...