Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2667133002: Compile video player with gyp v2. (Closed)

Created:
3 years, 10 months ago by oka
Modified:
3 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile video player with gyp v2. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2667133002 Cr-Commit-Position: refs/heads/master@{#447710} Committed: https://chromium.googlesource.com/chromium/src/+/3089da8cc164db9ecd7a16b0a884da072d9bab94

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -178 lines) Patch
M third_party/closure_compiler/compiled_resources.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/file_manager/video_player/js/cast/compiled_resources2.gyp View 1 chunk +35 lines, -16 lines 0 comments Download
D ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +0 lines, -137 lines 0 comments Download
M ui/file_manager/video_player/js/compiled_resources2.gyp View 2 chunks +43 lines, -20 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
oka
PTAL.
3 years, 10 months ago (2017-02-01 13:52:00 UTC) #4
fukino
lgtm
3 years, 10 months ago (2017-02-02 00:23:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667133002/1
3 years, 10 months ago (2017-02-02 04:03:54 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/closure_compiler/compiled_resources.gyp: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-02 05:13:17 UTC) #12
oka
Rebased.
3 years, 10 months ago (2017-02-02 05:55:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667133002/20001
3 years, 10 months ago (2017-02-02 05:56:14 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:38:39 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3089da8cc164db9ecd7a16b0a884...

Powered by Google App Engine
This is Rietveld 408576698