Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2667013002: doc.write intervention warning message changed to replace cross-origin with cross site (etld+1) BUG… (Closed)

Created:
3 years, 10 months ago by shivanisha
Modified:
3 years, 10 months ago
Reviewers:
Bryan McQuade
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, csharrison+watch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+metrics_chromium.org, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

doc.write intervention warning message changed to replace cross-origin with cross site (etld+1) BUG=658983 Review-Url: https://codereview.chromium.org/2474943002 Cr-Commit-Position: refs/heads/master@{#446993} (cherry picked from commit 52c2ea5fbafcf7efc85e8f8fc4865073f3b6aaf1) BUG=658983 TBR=bmcquade@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2667013002 Cr-Commit-Position: refs/branch-heads/2987@{#246} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/2965f49595126e50e902de401f7f53c70b7a80a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -26 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-effectively-2g-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-reload-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 3 chunks +22 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
shivanisha
3 years, 10 months ago (2017-01-31 20:27:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667013002/1
3 years, 10 months ago (2017-01-31 20:29:04 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-31 20:29:05 UTC) #5
shivanisha
On 2017/01/31 at 20:29:05, commit-bot wrote: > No L-G-T-M from a valid reviewer yet. > ...
3 years, 10 months ago (2017-01-31 20:36:13 UTC) #6
Bryan McQuade
lgtm
3 years, 10 months ago (2017-02-01 15:29:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667013002/1
3 years, 10 months ago (2017-02-01 15:51:46 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-01 15:51:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667013002/1
3 years, 10 months ago (2017-02-01 15:53:32 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 15:55:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2965f49595126e50e902de401f7f...

Powered by Google App Engine
This is Rietveld 408576698