Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: tests/compiler/dart2js/kernel/loops_test.dart

Issue 2667003005: Use for-in loop variable name if possible (Closed)
Patch Set: also non-indexed loops Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder_kernel.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/kernel/loops_test.dart
diff --git a/tests/compiler/dart2js/kernel/loops_test.dart b/tests/compiler/dart2js/kernel/loops_test.dart
index b257e4b009e922c2b621e38207ad25acf53948af..13a75e759e82f50e6ae6d5a719e7ee500c2c631b 100644
--- a/tests/compiler/dart2js/kernel/loops_test.dart
+++ b/tests/compiler/dart2js/kernel/loops_test.dart
@@ -52,10 +52,8 @@ main() {
}
return sum;
}''';
- // TODO(het): Check that the code is alpha-equivalent. That is,
- // the same except for variable names.
return check(code);
- }, skip: "The output is the same, with one variable renamed");
+ });
test('for-in loop optimized', () {
String code = '''
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder_kernel.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698