Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2667003005: Use for-in loop variable name if possible (Closed)
Patch Set: also non-indexed loops Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/kernel/loops_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index 551be940de95cc5fc71ebac2af93ba7facf3ba05..3135ad57debad21257da42838b2eb8fc1c30f48e 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -811,8 +811,12 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
HInstruction value = new HIndex(array, index, null, type);
add(value);
- localsHandler.updateLocal(
- astAdapter.getLocal(forInStatement.variable), value);
+ Local loopVariableLocal = astAdapter.getLocal(forInStatement.variable);
+ localsHandler.updateLocal(loopVariableLocal, value);
+ // Hint to name loop value after name of loop variable.
+ if (loopVariableLocal is !SyntheticLocal) {
+ value.sourceElement ??= loopVariableLocal;
+ }
forInStatement.body.accept(this);
}
@@ -868,8 +872,13 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
TypeMask mask = astAdapter.typeOfIteratorCurrent(forInStatement);
_pushDynamicInvocation(forInStatement, mask, [iterator],
selector: Selectors.current);
- localsHandler.updateLocal(
- astAdapter.getLocal(forInStatement.variable), pop());
+ Local loopVariableLocal = astAdapter.getLocal(forInStatement.variable);
+ HInstruction value = pop();
+ localsHandler.updateLocal(loopVariableLocal, value);
+ // Hint to name loop value after name of loop variable.
+ if (loopVariableLocal is !SyntheticLocal) {
+ value.sourceElement ??= loopVariableLocal;
+ }
forInStatement.body.accept(this);
}
« no previous file with comments | « no previous file | tests/compiler/dart2js/kernel/loops_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698