Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2667003005: Use for-in loop variable name if possible (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : also non-indexed loops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 chunks +13 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/loops_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 10 months ago (2017-02-02 22:58:09 UTC) #3
Emily Fortuna
lgtm source element!
3 years, 10 months ago (2017-02-02 23:07:21 UTC) #4
sra1
3 years, 10 months ago (2017-02-03 21:51:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
49c97bc13f83cdda0a147915ea8412bb4d289fef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698