Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2667003003: Revert of Force compositing inputs to be clean for getBoundingClientRect (Closed)

Created:
3 years, 10 months ago by johnme
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Force compositing inputs to be clean for getBoundingClientRect (patchset #14 id:250001 of https://codereview.chromium.org/2647533002/ ) Reason for revert: transitions/unprefixed-transform-origin.html has failed on almost every build of WebKit Mac10.11 (dbg) and WebKit Linux Trusty (dbg) since this patch landed. Each time it's because the transitionend event fails to fire for property -webkit-transform-origin-z. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=transitions%2Funprefixed-transform-origin.html&testType=webkit_tests Original issue's description: > Force compositing inputs to be clean for location-related Element APIs > > After layout, the location of position:sticky elements and their descendants > will be incorrect until compositing inputs have been cleaned. In most cases > this is not an issue since Blink will run a full lifecycle after page change, > including compositing. However if the user modifies layout during a script and > then calls a location-based API without yielding, compositing inputs would > still be dirty. This patch corrects that behavior by ensuring that compositing > inputs are clean for location-related APIs. > > BUG=672457 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2647533002 > Cr-Commit-Position: refs/heads/master@{#447158} > Committed: https://chromium.googlesource.com/chromium/src/+/2c04a7850056a21b6c1dcb6d63451c4a0f11e707 TBR=chrishtr@chromium.org,flackr@chromium.org,suzyh@chromium.org,kozyatinskiy@chromium.org,smcgruer@chromium.org NOTRY=true NOTREECHECKS=true BUG=672457 Review-Url: https://codereview.chromium.org/2667003003 Cr-Commit-Position: refs/heads/master@{#447542} Committed: https://chromium.googlesource.com/chromium/src/+/66c36f258e7ef15d44b8fd7d2766943da38cc40c

Patch Set 1 #

Messages

Total messages: 14 (8 generated)
johnme
Created Revert of Force compositing inputs to be clean for getBoundingClientRect
3 years, 10 months ago (2017-02-01 13:00:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667003003/1
3 years, 10 months ago (2017-02-01 13:00:16 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/110673)
3 years, 10 months ago (2017-02-01 14:31:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667003003/1
3 years, 10 months ago (2017-02-01 16:27:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667003003/1
3 years, 10 months ago (2017-02-01 16:59:43 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 17:05:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66c36f258e7ef15d44b8fd7d2766...

Powered by Google App Engine
This is Rietveld 408576698