Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2666993006: Enable ParseHTMLOnMainThread on TOT (Closed)

Created:
3 years, 10 months ago by Charlie Harrison
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, esprehn, jam, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ParseHTMLOnMainThread on TOT See the loading-dev@ thread for more context: https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/_cXkjQ0-L_E BUG=623165 Review-Url: https://codereview.chromium.org/2666993006 Cr-Commit-Position: refs/heads/master@{#447966} Committed: https://chromium.googlesource.com/chromium/src/+/144ab5c952cfce3ac747c4a52aafdf99d2b98089

Patch Set 1 #

Patch Set 2 : clean up virtual test suites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -191 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/parsehtmlonmainthread_coalesce/fast/parser/README.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/parsehtmlonmainthread_sync/fast/parser/README.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/CoreInitializer.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.json5 View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 11 chunks +28 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/TokenizedChunkQueue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/TokenizedChunkQueue.cpp View 2 chunks +1 line, -33 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
Charlie Harrison
kouhei: PTAL? I tried to make this a minimum change that removes - postTaskToLookaheadparser - ...
3 years, 10 months ago (2017-02-01 23:12:22 UTC) #7
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-02-01 23:33:03 UTC) #9
kouhei (in TOK)
PS2 still lgtm
3 years, 10 months ago (2017-02-01 23:35:09 UTC) #10
Charlie Harrison
Thanks kouhei! +jochen for content and rest of Blink (-core) +isherman for field trial configs
3 years, 10 months ago (2017-02-01 23:40:13 UTC) #12
Ilya Sherman
testing/variations/fieldtrial_testing_config.json lgtm
3 years, 10 months ago (2017-02-01 23:48:12 UTC) #13
Charlie Harrison
cc esprehn, yoav
3 years, 10 months ago (2017-02-01 23:48:24 UTC) #14
jochen (gone - plz use gerrit)
can we have a PSA on blink-dev please?
3 years, 10 months ago (2017-02-03 06:26:02 UTC) #15
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-03 06:26:38 UTC) #16
Charlie Harrison
Sent the PSA, going to send to CQ. Thanks for the review, Jochen.
3 years, 10 months ago (2017-02-03 06:57:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666993006/20001
3 years, 10 months ago (2017-02-03 06:57:52 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/144ab5c952cfce3ac747c4a52aafdf99d2b98089
3 years, 10 months ago (2017-02-03 09:25:50 UTC) #22
Yoav Weiss
3 years, 10 months ago (2017-02-03 14:43:02 UTC) #23
Message was sent while issue was closed. 
On 2017/02/03 09:25:50, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/144ab5c952cfce3ac747c4a52aaf...

Yay!

Powered by Google App Engine
This is Rietveld 408576698