Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2666953004: third_party: Amend version 2 of remote shell protocol (Closed)

Created:
3 years, 10 months ago by Dominik Laskowski
Modified:
3 years, 10 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party: Amend version 2 of remote shell protocol The "configure" event and "ack_configure" request enable the compositor to synchronize window positions across display configuration changes. In extended desktop mode, this prevents a race that causes windows to briefly appear at an incorrect location when a display is connected or disconnected. BUG=642894 TEST=None Review-Url: https://codereview.chromium.org/2666953004 Cr-Commit-Position: refs/heads/master@{#447587} Committed: https://chromium.googlesource.com/chromium/src/+/e44a9c858468ba0cbd00643bd7d61ae4eda2285b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -60 lines) Patch
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 6 chunks +133 lines, -50 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 5 chunks +157 lines, -8 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dominik Laskowski
PTAL.
3 years, 10 months ago (2017-02-01 19:29:25 UTC) #4
reveman
lgtm
3 years, 10 months ago (2017-02-01 19:43:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666953004/1
3 years, 10 months ago (2017-02-01 20:01:17 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:06:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e44a9c858468ba0cbd00643bd7d6...

Powered by Google App Engine
This is Rietveld 408576698