Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2666893003: [turbofan] Put GrowFastElements stub call into deferred code. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Put GrowFastElements stub call into deferred code. With this fix we generate straightline code again for the fast case, just like Crankshaft. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2666893003 Cr-Commit-Position: refs/heads/master@{#42814} Committed: https://chromium.googlesource.com/v8/v8/+/28dc846ff3787f42fd8c8016d750d244e6cb9444

Patch Set 1 #

Patch Set 2 : And fix the naming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-31 13:44:47 UTC) #1
Jarin
lgtm (but could you fix the label name as well?)
3 years, 10 months ago (2017-01-31 13:47:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666893003/20001
3 years, 10 months ago (2017-01-31 13:48:27 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 14:13:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/28dc846ff3787f42fd8c8016d750d244e6c...

Powered by Google App Engine
This is Rietveld 408576698